32QAM

[safarisadegh]

Hi, Thank you for your great repo. My question is when will 32-QAM (and other square powers of 2) be available on pyphysim?

[darcamo]

Sorry for the (very) late answer.

I don't have much free time to work on pyphysim, unless it is something I particularly need. Unfortunately, non-square QAM is not one of them. However, it should be easy to implement.

Most of the code for fundamental modulators (QAM, PSK, etc) is in the pyphysim.modulators.fundamental.Modulator class. Subclasses such as QAM need to implement only a method to generate the constellation, as well as the calcTheoreticalSER and calcTheoreticalBER methods.

The code in the QAM class is only valid for squared constellations and currently it raises an exception for non-squared constellations. If you want to extend it to non-square constellations (or if you already did) I would gladly accept pull requests.