Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report file set does not work for "created" or "createdOrModified" groups #56

Open
pc-mwong opened this issue Sep 30, 2020 · 1 comment

Comments

@pc-mwong
Copy link

pc-mwong commented Sep 30, 2020

Hello , the following config options do not seem to work as expected.

Issue Summary:

  • Files are not displayed when using these two options for "created" and "createdOrModified"
  • Code coverage report is correctly displayed when using "all"

Investigation Results:

  • possibly filterForCoveredFiles is failing to return an array of files
  • seems like file paths are not in sync for files found with danger.git.modified_files vs files from coverage

My setup:

const coverageConfig = {
  coveragePath: {
    path: path.resolve(
      __dirname,
      "...customPath/coverage-summary.json"
    ),
    type: "json-summary"
  },
  reportMode: "warn",
  entrySortMethod: "least-coverage",
  reportFileSet: "createdOrModified",
  numberOfEntries: 20,
  threshold: {
    statements: 40,
    branches: 40,
    functions: 40,
    lines: 40
  }
};

@pc-mwong pc-mwong changed the title reportFileSet does not work for created and createdOrModified config options Report file set does not work for "created" or "createdOrModified" groups Sep 30, 2020
@pc-mwong
Copy link
Author

pc-mwong commented Oct 9, 2020

After investigating this further,

I discovered the file paths from coverage-summary.json and danger.git.modified_files do not match when using the public danger github action

I've switched to run danger directly instead of using the github action which "solved" the issue.

this is still seems to be a valid issue with the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant