Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open links in new tab? #36

Open
thle opened this issue Apr 13, 2022 · 3 comments · May be fixed by darekkay/static-marks-app#7
Open

Open links in new tab? #36

thle opened this issue Apr 13, 2022 · 3 comments · May be fixed by darekkay/static-marks-app#7
Labels
good first issue Good for newcomers Type: Enhancement New feature or request

Comments

@thle
Copy link

thle commented Apr 13, 2022

Hi,
sorry for the question, I use this for some time now but did update to the current version just some weeks ago. Sometime the default behavior was to open links in new tabs or windows - has this changed, can I get this back somehow?

Thanks
@darekkay darekkay added the Type: Enhancement New feature or request label Apr 13, 2022
@darekkay
Copy link
Owner

Hey @thle ,
you're right, I've changed the behavior unintentionally in this commit by removing defaultProps. Version 2.2.7 is probably the one before introducing the bug.

From my daily Static Marks usage I like the new behavior more - I almost always open Static Marks to navigate to a single bookmark and I don't require the app to remain open. But I can understand that other people might want a different behavior. I suggest to make this a config option.

@thle
Copy link
Author

thle commented Apr 13, 2022

That would be nice. I use it contrarily, open SM as the first tab or even start page of the browser, opening new tabs from it, closing them and so on.

@darekkay darekkay added the good first issue Good for newcomers label Apr 28, 2022
@arindamlahiri
Copy link

arindamlahiri commented Sep 18, 2022 •
edited

Hey @darekkay I want to work on this, can you please assign it to me?

@arindamlahiri arindamlahiri linked a pull request Sep 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open links in new tab arindamlahiri/static-marks-app
3 participants
@thle @darekkay @arindamlahiri