Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On mobile: move search bar to the bottom #42

Open
Jiehong opened this issue Jan 10, 2023 · 2 comments
Open

On mobile: move search bar to the bottom #42

Jiehong opened this issue Jan 10, 2023 · 2 comments
Labels
Type: Enhancement New feature or request

Comments

@Jiehong
Copy link

Jiehong commented Jan 10, 2023

Hello there,

On mobile, the "Search everywhere..." search bar is located at the top, which is nice, but is a bit far for most people's fingers.

Today, mobile browsers even have the url bar at the bottom for reachability purposes.

Would it be possible to have the search bar be sticky at the bottom on the viewport instead of at the top?

Basically having bottom: 0 instead of top: 0 for header and setting top: 0 instead of top: 60px for main in the css.

WDYT?

@darekkay darekkay added the Type: Enhancement New feature or request label Jan 16, 2023
@darekkay
Copy link
Owner

Hello @Jiehong ,
thanks for the suggestion.

First of all, if this feature is to be implemented, I would like to make it configurable. Personally, I like the current behavior, but I understand that I might be in the minority.

The challenge will be to answer the question what "mobile" means. "Device width" is not a reliable factor, and can lead to issues (e.g. when resizing a desktop browser window). "Hover-able devices" will include tablets.

Having a fixed user configuration option independent of the device width etc. would fulfil your request without having to detect a mobile device. Would this cover your use case? Or do you have other suggestions?

@Jiehong
Copy link
Author

Jiehong commented Jan 20, 2023

I suppose that both a screen, width and pointer coarse would mostly match smartphones.

Although, today I see that .collections has a media query of @media screen and (min-width: 481px), so this could be a basis.

I think perhaps we could combine your last suggestion of a fixed user configuration that would alter the media query's css content accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants