Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lc_messages not in English #795

Open
Krysztophe opened this issue Sep 21, 2023 · 2 comments
Open

lc_messages not in English #795

Krysztophe opened this issue Sep 21, 2023 · 2 comments

Comments

@Krysztophe
Copy link
Owner

''lc_messages = C'' is not set by default by some customers, so I have already lost time generating empty reports before checking it.

  • A question: can we imagine having pgbadger understand other languages? Some day I feel motivated, but it is probably a long and buggy task to find and substitute all keywords hardcoded in the regex.

  • Easier: add a non-blocking warning if some non-English language is detected. Perhaps a regex with the translations of the most common keywords from the translations, tested only on the first 1000 lines?

@darold
Copy link
Owner

darold commented Sep 25, 2023

Hi Christophe,

About point 1, this is not an easy work, there are 14 language to support and I'm not sure that the Perl code will support Korean or Japanese words in the regexp.

The problem with point 2 is that this is common to have non-English language at start of the first log before lc_messages is changed.

@Krysztophe
Copy link
Owner Author

@gleu has launched a discussion about giving up the translation of server messages :
https://www.postgresql.org/message-id/flat/CAECtzeV6dyu4jTOrorFW%3DB%3DEicyejWO7_Seew3Ch0%3D0wO%2BM-RQ%40mail.gmail.com

  1. Making pgbadger aware of other languages would be tedious, but not impossible. We could support only the easiest languages at the beginning, and it would be easier to support the others.

  2. Well, I'll try if I find some time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants