Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression drill-down gone? #3

Open
davidszotten opened this issue Oct 19, 2018 · 4 comments
Open

expression drill-down gone? #3

davidszotten opened this issue Oct 19, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@davidszotten
Copy link

Hi,

Thanks for a great plugin!

While the diffs are super helpful, it looks like we lose the very handy drill-down output:

$ cat test.py
a = [1, 2, 3]
b = [1, 2]

def test_a():
    assert len(a) == len(b)

without plugin

    def test_a():
>       assert len(a) == len(b)
E       assert 3 == 2
E        +  where 3 = len([1, 2, 3])        <-- i miss these
E        +  and   2 = len([1, 2])

with plugin

    def test_a():
>       assert len(a) == len(b)
E       assert left == right failed.
E         Showing split diff:
E
E         left:  3
E         right: 2      <--  really nice!

perhaps @nicoddemus has any advice/ideas on how to make this possible?

@darrenburns
Copy link
Owner

Good catch, totally forgot about this! It should be possible, but I'll take a closer look next week.

@darrenburns darrenburns added the enhancement New feature or request label Oct 19, 2018
@nickpresta
Copy link

@darrenburns any news on this front? Would you like some help on this enhancement?

@darrenburns
Copy link
Owner

Hi @nickpresta, I took a brief look into this a while back and found it to be trickier than I'd hoped, so I haven't made any progress on it. Any help would be greatly appreciated :)

@darrenburns darrenburns added the help wanted Extra attention is needed label Aug 1, 2019
@JBKahn
Copy link

JBKahn commented Oct 9, 2019

@darrenburns Check out this thread here: pytest-dev/pytest#5933

If that looks good, please chime in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants