Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dart-lang/build
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: build_runner-v2.4.6
Choose a base ref
...
head repository: dart-lang/build
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: build_runner-v2.4.7
Choose a head ref

Commits on Jun 29, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    dba681f View commit details

Commits on Jul 10, 2023

  1. Add required github deployment environment for publishing (#3544)

    Pass environment config to the publish action to harden our releases.
    
    Upon approval I will also update the publish settings on pub to require this environment.
    
    (see https://dart.dev/tools/pub/automated-publishing#hardening-security-with-github-deployment-environments)
    jakemac53 authored Jul 10, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3087308 View commit details

Commits on Jul 27, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e4d328f View commit details

Commits on Jul 28, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    508fd96 View commit details

Commits on Aug 9, 2023

  1. Copy the full SHA
    ef538e4 View commit details

Commits on Aug 30, 2023

  1. Compute and cache transitive digests as files in build_resolvers (#3556)

    Spawned from discussion [here](#3555 (comment)).
    
    - Adds a builder in build_resolvers which emits a file containing the transitive digest of the library and all its imports.
      - When computing the transitive digest, we always first look for transitive digest files next to all of our immediate library deps, if they exist we merge that file into our digest and don't crawl any deeper.
        - If we can't read any transitive dependency for some reason we emit a warning and just give up in the builder, which means we will never emit a transitive digest file for that library (which is fine, just not optimal).
    - The resolver reads these files to establish dependencies - for each library dependency we first check for a transitive digest file, if it exists we just read that and don't crawl that libraries deps. If it doesn't exist then we do the old behavior.
      - There is actually an additional step here that will continue the recursive crawl for libraries that have not yet been seen in order to load them into the resource provider for the analyzer.
    - I also exposed a shared resource to avoid duplicate parsing of libraries between the resolver itself and the transitive digest builder. We might eventually want to migrate this to a builder as well, and serialize that information to disk instead, which would avoid some unnecessary re-parsing of libraries on rebuilds.
    jakemac53 authored Aug 30, 2023
    Copy the full SHA
    307a5ab View commit details
  2. Copy the full SHA
    d47a527 View commit details

Commits on Sep 1, 2023

  1. Avoid passing a nullable value to Future<nn-type>.value (#3567)

    This is cleanup work required to start enforcing this with static analysis, as per dart-lang/sdk#53253.
    
    Real quick this issue is that this code is unsafe:
    
    ```dart
    void f(Completer<int> c, int? i) {
      Future<int>.value(i); // Ouch!
      c.complete(i);        // Ouch!
    }
    ```
    
    - Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
    
    ---
    
    <details>
      <summary>Contribution guidelines:</summary><br>
    
    - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs.
    - Larger or significant changes should be discussed in an issue before creating a PR.
    - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`.
    - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change).
    - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).
    
    Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
    </details>
    srawlins authored Sep 1, 2023
    Copy the full SHA
    627de7d View commit details
  2. unskip test that passes now (#3568)

    Closes #3428.
    jakemac53 authored Sep 1, 2023
    Copy the full SHA
    1bd7e4c View commit details
  3. fix broken link in readme (#3569)

    I am trying to see if we can re-enable the markdown checker as well (I just re-enabled the workflow).
    
    Fixes #3343
    jakemac53 authored Sep 1, 2023
    Copy the full SHA
    a4c7c54 View commit details
  4. Copy the full SHA
    9fa21b9 View commit details

Commits on Sep 6, 2023

  1. Skip delete for SDK summary and deps file (#3573)

    Fixes #2995
    
    When the summary file is determined to be invalid, regenerate it and
    overwrite it without deleting. This resolves a race condition where
    multiple resolvers could try to delete the same file. The invalid
    content will not be read, because we will regenerate the file before
    moving on to the rest of the build.
    natebosch authored Sep 6, 2023
    Copy the full SHA
    a161297 View commit details

Commits on Sep 20, 2023

  1. Fix an issue where multiple AnalyzerResolvers instances lead to incor…

    …rect behavior (#3580)
    
    Deprecate the unnamed AnalyzerResolvers constructor, replace it with a static instance getter and `AnalyzerResolvers.custom` factory constructor.
    
    These new APIs guarantee a 1:1 relationship between the BuildAssetUriResolver and an analysis engine, which is necessary to ensure `changeFile` is always called on each analysis engine when needed.
    
    Note that the deprecated constructor does not uphold this invariant, it remains backwards compatible with its old implementation, and uses the same BuildAssetUriResolver as the shared resolver.
    jakemac53 authored Sep 20, 2023
    Copy the full SHA
    292a623 View commit details

Commits on Sep 25, 2023

  1. Copy the full SHA
    bbd32a1 View commit details

Commits on Sep 28, 2023

  1. Notify the analyzer of deleted files (#3584)

    Related to dart-lang/source_gen#682.
    
    Deleted files were never getting a changeFile call and so they were still available in the analyzer. This exposed in particular old generated part files to subsequent builds which could cause weird errors.
    jakemac53 authored Sep 28, 2023
    Copy the full SHA
    e2c837b View commit details
  2. Copy the full SHA
    5eb5d9b View commit details

Commits on Sep 29, 2023

  1. Copy the full SHA
    2ba1102 View commit details

Commits on Oct 5, 2023

  1. Freshen docs for aggregate builders (#3590)

    Remove some references to the behavior of older versions of build_runner
    and build_resolvers. The changes were made in 2020, and we have had a
    major version change since the version which introduced the change.
    
    Change some docs about compatibility with older build_resolvers to
    instead describe the utility of splitting steps for improved
    invalidation behavior.
    natebosch authored Oct 5, 2023
    Copy the full SHA
    2a66be2 View commit details

Commits on Oct 6, 2023

  1. Copy the full SHA
    9fe0f98 View commit details

Commits on Oct 18, 2023

  1. Copy the full SHA
    ec7896c View commit details

Commits on Oct 30, 2023

  1. Copy the full SHA
    fae6ed1 View commit details

Commits on Nov 8, 2023

  1. use base64 encoded md5 hash of working dir to build the unique worksp…

    …ace dir (#3608)
    
    Also adds a dependency on package:crypto
    jakemac53 authored Nov 8, 2023
    Copy the full SHA
    766cf18 View commit details
  2. Copy the full SHA
    2550caf View commit details

Commits on Nov 17, 2023

  1. [web_compilers] Add support for js_interop_unsafe (#3613)

    Also bump min SDK
    Also prepare for release
    kevmoo authored Nov 17, 2023
    Copy the full SHA
    7f5b103 View commit details

Commits on Nov 28, 2023

  1. Copy the full SHA
    df76f89 View commit details
Loading