-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_A04_t04 should not expect that the target of the symlink must exist on Windows #2291
Labels
bad-test
Report tests in need of updates. When closed, the tests should be considered good
Comments
sgrekhov
added
the
bad-test
Report tests in need of updates. When closed, the tests should be considered good
label
Sep 28, 2023
According to the updated docs if we are create a |
Sure. The PR is documentation-only though. |
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this issue
Oct 6, 2023
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this issue
Oct 10, 2023
eernstg
pushed a commit
that referenced
this issue
Oct 10, 2023
eernstg
pushed a commit
that referenced
this issue
Oct 11, 2023
…2299) Update `Link.create()` tests according to the documentation. Add more tests for calling create() with existing path.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Oct 15, 2023
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2310. Fix new roll failures (dart-lang/co19#2311) 2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2306. Fix promoted instance type in not_promotable_A01_t04.dart (dart-lang/co19#2309) 2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2307. Don't expect private fields promotion on static fields (dart-lang/co19#2308) 2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` tests according to the documentation (dart-lang/co19#2299) 2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 3 (dart-lang/co19#2294) 2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 4 (dynamic semantics) (dart-lang/co19#2296) 2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` according to the documentation. Part 2 (dart-lang/co19#2301) 2023-10-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2268. Fix LibTest/io/WebSocket/closeCode_A01_t02.dart to be not racy (dart-lang/co19#2302) 2023-10-09 sgrekhov22@gmail.com dart-lang/co19#1400. Add more tests for private fields promotion of extension types (dart-lang/co19#2300) Change-Id: Ib34f392c8a2a0aaab8b7b0cb028f918ab2a3249f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330460 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this issue
Oct 17, 2023
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this issue
Oct 18, 2023
eernstg
pushed a commit
that referenced
this issue
Oct 18, 2023
Add more `Link.createSync()` tests. Part 2
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Oct 24, 2023
2023-10-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2319. Fix roll failures (dart-lang/co19#2321) 2023-10-23 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more top types tests (dart-lang/co19#2322) 2023-10-18 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more superinterfaces tests (dart-lang/co19#2315) 2023-10-18 sgrekhov22@gmail.com dart-lang/co19#2291. Add more Link.createSync() tests. Part 2 (dart-lang/co19#2316) 2023-10-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2304. Add more `Object` member tests (dart-lang/co19#2312) 2023-10-17 sgrekhov22@gmail.com dart-lang/co19#2313. Fix expected static type in upper_bound_A01_t05.dart (dart-lang/co19#2314) Change-Id: Id5279b7bad5e45c7e8a5d2fa7cbffe49bd1b2093 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331860 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
eernstg
pushed a commit
that referenced
this issue
Oct 25, 2023
… Part 1 (#2305) Update `Link.createSync()` according to the new documentation. Part 1
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Oct 27, 2023
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2329. Fix FileSystemEntity.type() on Windows (dart-lang/co19#2332) 2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2330. Remove obsolete error expectation (dart-lang/co19#2331) 2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2317. Add tests for extension type type parameters in non-covariant position (dart-lang/co19#2318) 2023-10-25 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.createSync()` according to the new documentation. Part 1 (dart-lang/co19#2305) 2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2313. [Extension types] Add nullability tests (dart-lang/co19#2324) 2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2323. Delete obsolete test (dart-lang/co19#2327) 2023-10-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2323. Don't test datagram size more than 65503 (dart-lang/co19#2325) Change-Id: I23b57a58b5cd6452e2beb923dd8cde6fd587f051 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332206 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the relevant code.
I've updated the docs in this PR.
I think that this test can just be deleted.
The text was updated successfully, but these errors were encountered: