-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare_for_embedded.dart
should use a fixed Cronet version
#1100
Comments
Any thoughts about this @AlexV525 ? |
It should be a corresponding version of the GMS version. Is the dependabot be able to do this? |
Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in |
Unfortunately no |
I don't know the answer regarding dependabot. |
Well that is just my idea. I'll do some investigation about it, before that we can find the correct version and apply it first. |
@brianquinlan Are you able contact owners of Cronet to know about version mapping between GMS and non-GMS versions? |
prepare_for_embedded.dart
updatesbuild.gradle
to use the latest version of Cronet.This leads to the possible problem that the version of Cronet included in a release may not have been tested.
Instead, we should set an explicit version in
prepare_for_embedded.dart
.The text was updated successfully, but these errors were encountered: