Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macros] support for avoid_equals_and_hash_code_on_mutable_classes #4932

Open
Tracked by #4881
pq opened this issue Apr 11, 2024 · 2 comments
Open
Tracked by #4881

[macros] support for avoid_equals_and_hash_code_on_mutable_classes #4932

pq opened this issue Apr 11, 2024 · 2 comments
Assignees
@pq
Labels
new-language-feature P2 A bug or feature request we're likely to work on status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Apr 11, 2024 •
edited

TODO: detect @immutable annotations added via class augmentations.
@pq pq added P2 A bug or feature request we're likely to work on new-language-feature labels Apr 11, 2024
@pq pq mentioned this issue Apr 11, 2024
Open
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Apr 12, 2024
@pq pq self-assigned this Apr 16, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 16, 2024
@pq
augmentation support for avoid_equals_and_hash_code_on_mutable_classes
9330195 
Fixes: dart-lang/linter#4932

Change-Id: Ic9b20d81ae36536251568dbf25616b9ddc9f6693
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363142
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@pq
Copy link
Member Author

pq commented Apr 16, 2024

Fixed w/ dart-lang/sdk@9330195

@pq pq closed this as completed Apr 16, 2024
@pq pq reopened this May 8, 2024
@pq
Copy link
Member Author

pq commented May 8, 2024

Currently blocked on analyzer implementation:

class AugmentedInstanceElementImpl {
  @override
  // TODO(scheglov): implement metadata
  List<ElementAnnotationImpl> get metadata => throw UnimplementedError();
}

@pq pq added the status-blocked Blocked from making progress by another (referenced) issue label May 8, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 8, 2024
@pq
failing test for classes marked @immutable in augmentation
bae8334 
Implementation is currently blocked on `augmented.metadata` which throws an unimplemented exception in `AugmentedInstanceElementImpl`.

See: dart-lang/linter#4932







Change-Id: I4dfd542ca9b7699deeadcd85098184f7ac82b4ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365923
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
new-language-feature P2 A bug or feature request we're likely to work on status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @srawlins