Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply directives_ordering to part #4945

Open
FMorschel opened this issue Apr 19, 2024 · 1 comment
Open

Apply directives_ordering to part #4945

FMorschel opened this issue Apr 19, 2024 · 1 comment
Labels
false-negative P2 A bug or feature request we're likely to work on

Comments

@FMorschel
Copy link
Contributor

Describe the issue
There is the directives_ordering. It does not apply to part, only import and export.

To Reproduce

  • Create a simple project.
  • Ensure directives_ordering is being used:
linter:
  rules:
    directives_ordering: true
  • Create 2 new files a.dart and b.dart inside lib.
  • Make them part of main.dart:
part 'b.dart';
part 'a.dart';

Expected behavior
To trigger directives_ordering lint.

Additional context
If you disagree with adding this rule to directives_ordering, then maybe we could create a new linter to that.

@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on false-negative labels Apr 19, 2024
@bwilkerson
Copy link
Member

It does seem reasonable to me that the lint should check part directives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false-negative P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

2 participants