Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] Support adding new assets in hook/link.dart #1084

Open
dcharkes opened this issue Apr 9, 2024 · 1 comment
Open

[native_assets_cli] Support adding new assets in hook/link.dart #1084

dcharkes opened this issue Apr 9, 2024 · 1 comment
Labels
P3 A lower priority bug or feature request package:native_assets_cli

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Apr 9, 2024

This needs to be supported downstream:

After we support adding assets in link hooks, we should update the doc comments on link.

The current workaround is to always add assets in hook/build.dart. @mosuem doesn't this workaround actually lead to duplicate assets? We would be "overriding" assets from the build hook with the link hook output. (Maybe I should prio the two above issues and the ones blocking that.)

@dcharkes dcharkes added P3 A lower priority bug or feature request package:native_assets_cli labels Apr 9, 2024
@mosuem
Copy link
Member

mosuem commented Apr 9, 2024

Adding new assets in link.dart is not a priority I would say - but it would need some checking to avoid duplicating assets, or a policy on how to resolve duplicate assets.

@dcharkes dcharkes mentioned this issue Apr 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request package:native_assets_cli
Projects
None yet
Development

No branches or pull requests

2 participants