Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSMutableArray.arrayWithContentsOfFile has different return types #1137

Open
liamappelbe opened this issue May 13, 2024 · 0 comments
Open

NSMutableArray.arrayWithContentsOfFile has different return types #1137

liamappelbe opened this issue May 13, 2024 · 0 comments
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute) package:objective_c type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@liamappelbe
Copy link
Contributor

NSMutableArray? arrayWithContentsOfFile:(NSString path)
NSArray? arrayWithContentsOfFile:(NSString path)

There are a few cases like this and it's one remaining source of "duplicate method" log spam. The important thing is that NSMutableArray is a subtype of NSArray, so we probably need to add some sort of subtyping test to handle this case. The fix is just to detect this case and keep the subtype version.

@liamappelbe liamappelbe added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) good first issue A good starting issue for contributors (issues with this label will appear in /contribute) package:objective_c labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute) package:objective_c type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
Status: Backlog
Development

No branches or pull requests

1 participant