Avoid thrown/caught exceptions when using HttpClient.openUrl (and related methods) with hostnames #52423
Assignees
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
cherry-pick-candidate
Candidates to be cherry-picked
library-io
P2
A bug or feature request we're likely to work on
Comments
2 tasks
lrhn
added
area-core-library
|
I am facing the same kind of issue, please seek it out on time. |
a-siva
added
P2
copybara-service bot
pushed a commit
that referenced
this issue
May 22, 2023
Bug:#52423 Change-Id: I3574cf9a33bd72d02a619afcf20a8a6eec835438 Tested: covered by existing tests Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304827 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Brian Quinlan <bquinlan@google.com>
|
A fix is in place. I'll go through the cherrypick process tomorrow. |
copybara-service bot
pushed a commit
that referenced
this issue
May 30, 2023
Bug:#52423 Change-Id: I8f3d63ddc0f2d0f768a7fa5219c883761bd9fa61 Tested: covered by existing tests Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/304827 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305041 Commit-Queue: Brian Quinlan <bquinlan@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a recent change (d884d1a) to fix #50868, there are calls to
_InternetAddress.fromString()that will throw (and then catch)ArgumentErrorwhenever the URI contains a hostname and not an IP address.This is not itself a bug/problem and everything works as expected. However, a lot of users are running with "break on all exceptions" ticked in VS Code and breaking here is causing some confusion. I've explained the issue here although that's not very visible unless you read the entire thread.
I think that issue should probably be closed (because as far as I can tell everything is working as expected), but since fetching URLs using hostnames is very common I thought it was worth seeing if that code could be altered to not rely on throwing/catching for this flow. While I think users shouldn't generally run with "Break on all exceptions" enabled (the default is "Break on uncaught exceptions"), the less "noise" there is when running in that mode, the easier it'll be to track down actual issues caused by unexpected exceptions being thrown and caught.
The text was updated successfully, but these errors were encountered: