[CP] fix needed for node 21

[sigmundch]

Commit(s) to merge

e285a57

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/331323

Issue Description

Applications built with dart2js fail in the most recent release of node.js (node.js 21). This was caused by logic we relied on for years to adjust the program to its underlying runtime (browser, node, d8, jsshell).

What is the fix

A small adjustment to the logic that detects properties about the underlying runtime.

Why cherry-pick

This affects a lot of users. This doesn't affect applications deployed to browsers, but affects any binary deployed to node.js. That includes big projects like dart-sass.

The fix is also relatively simple and contained (Note that the bulkier change is on a test file called js_membrers.dart). It has passed all of our current tests that provide coverage on all other relevant environments (e.g. browsers)

Risk

low

Issue link(s)

#53784

cc @rakudrama @natebiggs

[sigmundch]

@itsjustkevin - let me know if you have any questions. For context on the severity for dart-sass, see #53784 (comment)

Hope this can go on next week's release 🤞

[itsjustkevin]

@rakudrama thoughts on this cherry-pick?

[rakudrama]

@rakudrama thoughts on this cherry-pick?

We should do it. The affected code has been stable for a long time - this reduces risk. Our primary use-case for dart2js on nodejs is broken. While it is not exactly our fault, we can help unblock the ecosystem.

[itsjustkevin]

Perfect, @sigmundch merge away!!!

[sigmundch]

thank you!

[gajus]

Looks like the linked commit was merged. Where can I track the next steps?

[itsjustkevin]

Hey @gajus there are no next steps for this cherry-pick, it has been merged and is in queue to be included in the next stable hotfix.

The issue will remain open until the fix has been landed in the stable branch.

[gajus]

Amazing. Thank you for the update.

What's the cadence for these hotfixes?

[itsjustkevin]

@gajus we attempt to release a beta or stable hotfix weekly if there are changes queued. There are times when this does not occur, but this is our general cadence.

[Uzlopak]

In node 21.1.0 navigator has now userAgent. Is your issue now solved?