Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeChecker.isAssignableFromType does not consider nullability #589

Open
simc opened this issue Feb 18, 2022 · 3 comments
Open

TypeChecker.isAssignableFromType does not consider nullability #589

simc opened this issue Feb 18, 2022 · 3 comments

Comments

@simc
Copy link

simc commented Feb 18, 2022 •
edited

I would expect TypeChecker.isAssignableFromType(staticType) to take the nullability of the types into account. It returns true incorrectly if the TypeChecker type is not nullable but staticType is nullable.

Dart SDK version: 2.16.1
@lrhn
Copy link
Member

lrhn commented Feb 18, 2022

Is this the TypeChecker from package:source_gen? (If so, the issue would fit better in https://github.com/dart-lang/source_gen/issues).

@simc
Copy link
Author

simc commented Feb 18, 2022

@lrhn yes, sorry! Should I close here and reopen or can you move the issue?

@lrhn lrhn transferred this issue from dart-lang/sdk Feb 18, 2022
@lrhn
Copy link
Member

lrhn commented Feb 18, 2022

Turns out I can, so moved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrhn @simc