Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LibraryReader.pathToUrl take a non-null argument #672

Open
natebosch opened this issue Jun 26, 2023 · 0 comments
Open

Make LibraryReader.pathToUrl take a non-null argument #672

natebosch opened this issue Jun 26, 2023 · 0 comments
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump

Comments

@natebosch
Copy link
Member

It is statically breaking to move the runtime null check to a static null check, but it's worth doing because a static check is preferred over a runtime check.
@natebosch natebosch added the next-breaking-release Issues that are worth doing but need to wait for a breaking version bump label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natebosch