Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin setuptools in dask-gateway-server's build environment #740

Open
consideRatio opened this issue Sep 22, 2023 · 1 comment
Open

Unpin setuptools in dask-gateway-server's build environment #740

consideRatio opened this issue Sep 22, 2023 · 1 comment
Labels
help wanted Extra attention is needed maintenance

Comments

@consideRatio
Copy link
Collaborator

consideRatio commented Sep 22, 2023

I pinned setuptools in the build environment for the dask-gateway-server package to ==63.* as I didn't know another way of resolving the issue.

setuptools in the build environment for dask-gateway-server is now pinned to 63 because 64+ has introduced the "editable_wheel" command to replace the "develop" command, and the editable_wheel command doesn't respect package_data config. We rely on that to get our golang built proxy accessible currently!

Message when using "setuptools>=64" during "pip install --editable .":

Editable install will be performed using a meta path finder.

Options like package-data, include/exclude-package-data or
packages.find.exclude/include may have no effect.

The problematic result is that we end up without a golang binary in dask_gateway_server/proxy/dask-gateway-proxy.

Related

@consideRatio
Copy link
Collaborator Author

consideRatio commented Nov 23, 2023

This is holding back dask-gateway-server working on Python 3.12, because the pinned setuptools is too old to work on Python 3.12 :'(

In #778 we break the editable install in Python 3.12 to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed maintenance
Projects
None yet
Development

No branches or pull requests

1 participant