Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-start-dask doesn't support notebook restarts #84

Open
mrocklin opened this issue Aug 26, 2019 · 3 comments
Open

Auto-start-dask doesn't support notebook restarts #84

mrocklin opened this issue Aug 26, 2019 · 3 comments

Comments

@mrocklin
Copy link
Member

If I engage the "Auto start Dask" option then my notebook gets the client state in it automatically. However, if I then restart my notebook I seem to lose that state.

@mrocklin
Copy link
Member Author

@ian-r-rose any thoughts on how one might resolve this?

@mrocklin
Copy link
Member Author

Poke @ian-r-rose , I think that @jsignell has some time to work on this this week. If you have time to provide a bit of high level guidance on where to start I suspect that we can clear this out.

@ian-r-rose
Copy link
Collaborator

Sorry for the slow response @mrocklin. I'd be happy to get an extra set of hands on this if you have the time @jsignell.

I have the start of a fix here. The regression here was due to a change in how the websocket connection was handled in kernel restarts due to this PR.

The tricky thing I ran into when I looked at this last was a race condition between user kernel interactions and the execute request that this extension sends upon restart. This particularly becomes an issue when the user restarts and begins executing cells immediately. We want our client connection code to be injected first, so any cells that depend on it work.

It's also worth noting that JupyterLab 2.0 (in RC right now) has some more changes to how kernel messages are handled (jupyterlab/jupyterlab#7252). I think that those changes might make this problem easier, but we'll probably have to look at that as well.

@TomAugspurger TomAugspurger moved this from In progress to Backlog in Core maintenance Mar 3, 2020
@jrbourbeau jrbourbeau moved this from Backlog to Sorted Backlog in Core maintenance Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core maintenance
Sorted Backlog
Development

No branches or pull requests

2 participants