Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package 'request' is using a buggy transitive dependency #850

Closed
aschrijver opened this issue Aug 16, 2017 · 3 comments
Closed

Package 'request' is using a buggy transitive dependency #850

aschrijver opened this issue Aug 16, 2017 · 3 comments

Comments

@aschrijver
Copy link

This issue is just to notify you that request depends on aws-sign2 v0.6.0 which has a bug in it: a duplicate export. This has been fixed in 0.7.0 but the wait is for a new release of request.
Probably this does not lead to issues with dat, I expect.

I created an issue, asking for a date:

(found this while testing rollup with dat project: request/request#2483)

@ralphtheninja
Copy link
Contributor

ralphtheninja commented Aug 16, 2017

Maybe we can swap out request for something else?

@aschrijver
Copy link
Author

@ralphtheninja Maybe its not that much of an issue. I have excluded it in the bundle.js and think its only for people wanting to connect to AWS or something. The bundling with rollup now works (it bundles, don't know if it executes yet :)

@okdistribute
Copy link
Collaborator

duplicate of #1176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants