Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint /values does not work for keys with / #110

Open
albanm opened this issue Dec 11, 2020 · 0 comments
Open

endpoint /values does not work for keys with / #110

albanm opened this issue Dec 11, 2020 · 0 comments

Comments

@albanm
Copy link
Member

albanm commented Dec 11, 2020

For example https://koumoul.com/s/data-fair/api/v1/datasets/operateur-atteste-gf/values/SIREN/SIRET?q_mode=simple&q=79316513500021

2 possibilities:

  • change the keys so that they don't contain this problematic char, the problem is after reindexing some datasets apis will be broken
  • make it work

We could limit the regression brought by the first solution by re-applying the escape key alg to inputs if the API (field query params, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant