Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unset session <session> #15498

Closed
BohuTANG opened this issue May 13, 2024 · 2 comments · Fixed by #15510
Closed

feat: unset session <session> #15498

BohuTANG opened this issue May 13, 2024 · 2 comments · Fixed by #15510
Assignees
Labels
C-feature Category: feature

Comments

@BohuTANG
Copy link
Member

BohuTANG commented May 13, 2024

Summary

Databend now supports the unset <settings> command, which is designed to remove global settings from the metasrv. We plan to expand this functionality with additional unset commands:

unset [session] <setting>; -- Only unset a setting at the session level.

For example:

-- load_file_metadata_expire_hours default is 248

set global load_file_metadata_expire_hours=12;
-- show settings like '%load_file_metadata_expire_hours%';
-- 12 global-level

set load_file_metadata_expire_hours=13;
-- show settings like '%load_file_metadata_expire_hours%';
-- 13 session-level

unset session load_file_metadata_expire_hours;
-- show settings like '%load_file_metadata_expire_hours%';
-- 12 global-level
@vaibhawvipul
Copy link

I would like to take this up, if no one is working on this.

@BohuTANG
Copy link
Member Author

@vaibhawvipul Thank you for considering this issue. However, it's not a good first issue as it has high priority in our plan, and we have some discussions and decisions to make regarding it.

We do have some other good first issues, but this one is highly recommended at the moment: #15295

Here is a list of all the good first issues:
https://github.com/datafuselabs/databend/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants