Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we rename ErrorCodes to ErrorCode? #778

Closed
drmingdrmer opened this issue Jun 8, 2021 · 2 comments · Fixed by #785
Closed

Should we rename ErrorCodes to ErrorCode? #778

drmingdrmer opened this issue Jun 8, 2021 · 2 comments · Fixed by #785
Labels
C-improvement Category: improvement

Comments

@drmingdrmer
Copy link
Member

Summary

ErrorCdoes is a struct that defines a single error code, not a collection of error codes

https://github.com/datafuselabs/datafuse/blob/fbe6bd8d3f761736ca03a1c932753320cd54e1b8/common/exception/src/exception.rs#L33-L40
@drmingdrmer drmingdrmer added the C-improvement Category: improvement label Jun 8, 2021
@BohuTANG
Copy link
Member

BohuTANG commented Jun 8, 2021

+1
cc @zhang2014

@zhang2014 zhang2014 mentioned this issue Jun 9, 2021
Merged
@databend-bot
Copy link
Member

Hello @datafuse-bot, 🎉 Thank you for opening an issue! 🎉
One of the maintainers of the project will respond as soon as possible. Seeing that you are new here, please familiarize yourself with our Roadmap and contributing to datafuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-improvement Category: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUES-778 rename ErrorCodes to ErrorCode zhang2014/datafuse
3 participants
@drmingdrmer @BohuTANG @databend-bot