Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: IsValid to accept 2nd param as dateFormat and validate date against it #1169

Closed
mukuljainx opened this issue May 15, 2019 · 5 comments
Closed

Feature Request: IsValid to accept 2nd param as dateFormat and validate date against it #1169

mukuljainx opened this issue May 15, 2019 · 5 comments
Labels
🎉 Feature ✋ Help wanted

Comments

@mukuljainx
Copy link
Contributor

Right now, isValid accepts the only date and cannot check date against a given format, it will really help if it can or any other function can check date, if provided as a string against a given format. I have already written code for it as it was required in one of my projects, will be happy to raise a PR if seems the valid case to others.
@kossnocorp
Copy link
Member

Sounds reasonable, but isValid is a bad place for that. I suggest creating a new function isMatch.

@mukuljainx
Copy link
Contributor Author

@kossnocorp, cool, I will raise a PR soon for isMatch 🤘

@kossnocorp
Copy link
Member

Thanks!

@kossnocorp kossnocorp mentioned this issue Jun 4, 2019
Closed
@mukuljainx
Copy link
Contributor Author

Hi, really sorry for being this late, it almost a year. I got busy with a lot of work and almost forgot about this!

I have raised a PR #1868

@vincent-h-lee
Copy link

Closed by #1868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 Feature ✋ Help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kossnocorp @mukuljainx @vincent-h-lee