Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottish Gaelic language support #1620

Closed
leedriscoll opened this issue Jan 29, 2020 · 8 comments · Fixed by #1832
Closed

Scottish Gaelic language support #1620

leedriscoll opened this issue Jan 29, 2020 · 8 comments · Fixed by #1832
Assignees

Comments

@leedriscoll
Copy link
Contributor

No description provided.

@dkozickis
Copy link
Contributor

@leedriscoll are you willing to provide PR for this one?

@leedriscoll
Copy link
Contributor Author

@dkozickis Absolutely, was just waiting for the green light to go ahead.

@dkozickis
Copy link
Contributor

Oh, that was not entirely obvious from your initial post :(

Please! Feel free 🙏🏻

I will assign this issue to you now. 🙇

@leedriscoll
Copy link
Contributor Author

Hey @dkozickis, I've pushed up a PR for Scottish Gaelic support - #1832. When will someone be able to take a look at this for me?

Is there anything I can do to speed up this process? 🙂

@12
Copy link

12 commented Jun 24, 2020

Hey, this would be really useful for a piece of work we have coming up.

Above PR looks all good to me, @dkozickis, do you have a timeframe on this being merged in?

@matt-rhys-jones
Copy link

Heya! I work with @leedriscoll and am the team lead for the redevelopment of the BBC News pages we'd like to launch using date-fns.

Is there any chance of letting us know when this might be merged @dkozickis? It would be really helpful to have an idea so we can plan around it, appreciate you're busy.

If there's anything Lee or I can do to help in the meantime please do let us know :)

@kossnocorp
Copy link
Member

@matt-rhys-jones hey, sorry for the delay. I've been swamped lately. I'll try to merge and ship a new version over the weekends or on the next week. However, I recommend you don't wait and simply copy-paste the locale code to your project and use it from there for the time being.

@kossnocorp
Copy link
Member

@matt-rhys-jones if you're looking for ways to help the project, I would appreciate BBC becoming date-fns sponsors at https://opencollective.com/date-fns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants