Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened to the addBusinessDays function? #3741

Open
davidhenley opened this issue Mar 21, 2024 · 3 comments · Fixed by #3742
Open

What happened to the addBusinessDays function? #3741

davidhenley opened this issue Mar 21, 2024 · 3 comments · Fixed by #3742

Comments

@davidhenley
Copy link
Contributor

At 3.0.0 this was removed from the docs? What am I missing?

@fturmel
Copy link
Member

fturmel commented Mar 21, 2024

Good catch! It looks like a bad @category jsdoc value at first glance, which would exclude the function from the docs.

Maybe we need some tests around this.

* @category Date Extension Helpers

* @category Day Helpers

date-fns/docs/config.js

Lines 7 to 28 in 8b63761

categories: [
"General",
"Misc",
"Common Helpers",
"Conversion Helpers",
"Interval Helpers",
"Timestamp Helpers",
"Millisecond Helpers",
"Second Helpers",
"Minute Helpers",
"Hour Helpers",
"Day Helpers",
"Weekday Helpers",
"Week Helpers",
"ISO Week Helpers",
"Month Helpers",
"Quarter Helpers",
"Year Helpers",
"ISO Week-Numbering Year Helpers",
"Decade Helpers",
"Generic Helpers",
],

@davidhenley
Copy link
Contributor Author

davidhenley commented Mar 21, 2024 via email

@fturmel fturmel linked a pull request Mar 21, 2024 that will close this issue
@kossnocorp
Copy link
Member

Thank you! Closed via 5c1adb5. It will go live with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants