Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify in isWeekend days #3757

Open
adrianjost opened this issue Apr 8, 2024 · 0 comments
Open

Clarify in isWeekend days #3757

adrianjost opened this issue Apr 8, 2024 · 0 comments

Comments

@adrianjost
Copy link

adrianjost commented Apr 8, 2024 •
edited

There is an issue with the isWeekend documentation

The problem with isWeekend documentation

It's not clear how "weekend" is defined. In some companies, Saturday is a working day, so not strictly speaking a weekend for all persons.
This is also seen in #2085.

Suggested edits

I would suggest adding the information that Saturday and Sunday are considered weekend days and those are the only ones checked in this utility.
@adrianjost adrianjost changed the title Problem in isWeekend documentation Clarify in isWeekend days Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrianjost