New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DST issue (closes #972, closes #992) #1003
Conversation
Remove code that causes #972. Most likely it will break something else, but this is yet to figure.
4ba1745
to
7150665
Compare
I think taking the next day into consideration causes weird behaviour in some cases. See: // import dateformat from 'date-fns/format'
> dateformat('2019-10-26T22:40:00')
"2019-10-26T23:40:00.000+02:00" ( date-fns version: 1.30.1 - this change was backported there. This is with a Europe/Berlin Browser/system timezone, we have DST change at 2019-10-27 03:00 (the day after that date). Sorry if this was already reported/fixed elsewhere, or I'm wrong / this is intended. Tbh. I didn't put too much effort into tracking it down further but it lead me here and I wanted to report it. Yep I see there is already #1500 so ignore this. |
Rework approach to DST handling to make it more bulletproof.
To do: