Rework toDate and extract parseISO #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kossnocorp
force-pushed
the
1016-parse-iso
branch
4 times, most recently
from
3b60192
to
48bbe0a
Compare
- Extract parseISO from toDate - Make toDate accept only numbers and dates
Fix DST issue in `eachDayOfInterval` that caused time in the days after DST change to have the shift as well.
kossnocorp
force-pushed
the
1016-parse-iso
branch
from
48bbe0a
to
838ed9f
Compare
leshakoss
reviewed
Jan 9, 2019
leshakoss
reviewed
Jan 9, 2019
leshakoss
reviewed
Jan 9, 2019
kossnocorp
commented
Jan 9, 2019
| 'Fri Mar 27 2020 01:00:00 GMT+0300 (Eastern European Summer Time)', | ||
| 'Sat Mar 28 2020 00:00:00 GMT+0300 (Eastern European Summer Time)' | ||
| ] | ||
| ) |
There was a problem hiding this comment.
I've messed up with the rebase, so for those who are looking for the actual fix: https://github.com/date-fns/date-fns/pull/1023/files#diff-5a48fe3ae25f8ac62336262cb0acd5e2
eostrom
added a commit
to eostrom/date-fns
that referenced
this pull request
Mar 23, 2019
Looks like this was updated when `parse` was renamed to `toDate`, (date-fns#375), but fell behind when ISO parsing was extracted from `toDate` into `parseISO` (date-fns#1023).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a result of an attempt to make minimal build size smaller. See #1015 for the background.
parseISOfromtoDatetoDateaccept only numbers and dateseachDayOfIntervalthat caused time in the days after DST change to have the shift as well.The results of the PR:
lightFormat:1.73 KB→887 BtoDate:1.27 KB→296 BaddDays:1.31 KB→385 BFor comparison, here are the v1 stats:
format:2.77 KBaddDays:983 B