Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue: options.weekStartsOn set to 1 doesn't work for Sundays #1046

Merged
merged 1 commit into from Aug 23, 2019

Conversation

waseemahmad31
Copy link
Contributor

fixed issue: #1040

When executing getWeekOfMonth(new Date(2019, 4, 5), { weekStartsOn: 1 }) it returns 2 while I expect it to be 1. It seems getWeekOfMonth() is always a week off when executed with a day set to Sunday and options.weekStartsOn set to > 0.

Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the bug. Good job! ⭐️

@leshakoss leshakoss merged commit 6244923 into date-fns:master Aug 23, 2019
@leshakoss
Copy link
Contributor

The fix was released as v2.0.1. Thanks for your contribution! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants