Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gujarati locale #1400

Merged
merged 2 commits into from Sep 6, 2019
Merged

Conversation

ManadayM
Copy link
Member

@ManadayM ManadayM commented Sep 1, 2019

This is to add support for Gujarati language. The language is native to Gujarat state of India and being spoken by 55 million people.

I have tried to adhere to the instructions for adding a new locale and the contribution rules. Still if something important is missing then kindly let me know.

PS:
This is my first PR to add a new feature on any open source project. :)

Manaday Mavani and others added 2 commits September 1, 2019 15:52
This commit adds support for Gujarati language.
This commit fixes the snapshot discrepancy between the reopsitory's travis-ci
and my local output.

The issue was due some platform differences as I was unable to get the expected
result on Windows 10 with `yarn locale-snapshots` command but when I executed on
WSL it emitted a different snapshot. Hope this will fix the issue.
Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for contribution! ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants