Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix French parsing issues with june and august #1430

Merged

Conversation

lovelovedokidoki
Copy link
Contributor

There are two typos in the parseMonthPatterns for French locale causing the parser to erroneously parse july as june and not parse august at all.

The pre-commit script wants to add newlines in between the list items, so changes might be hard to spot, but they are very few: It's just /^jui/i -> /^juin/i and /^au/i -> /^ao/i.

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR, thank you!

@kossnocorp kossnocorp merged commit e7e4dcf into date-fns:master Sep 24, 2019
@Lakston
Copy link
Contributor

Lakston commented Sep 25, 2019

Thanks for your contribution !
Merci pour ta contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants