Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vietnamese parsing patterns #1445

Merged

Conversation

lovelovedokidoki
Copy link
Contributor

Parsing data had a mismatch in narrow month format, causing all short format (PP, MMM, LLL) months to fail parsing (it was labeled short, which is not used in the parser for month formats).

Also, the method of parsing numbers from the end of the string instead of beginning was causing the parser to read the first number of the year instead of the month, causing incorrect month results on wide format. I took the liberty to conform all the patterns to search at the beginning of the string (removing $ and adding ^ instead), to avoid future confusion, using instead negative lookahead (?!\d) to prevent the interpreter from matching numbers partially.

@lovelovedokidoki lovelovedokidoki force-pushed the lmolgaardtams-fix-vietnamese-parsing branch from 08b6be2 to 8308284 Compare September 25, 2019 16:30
Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants