Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/throw messages #1641

Merged
merged 7 commits into from Jul 17, 2020
Merged

Refactor/throw messages #1641

merged 7 commits into from Jul 17, 2020

Conversation

belgamo
Copy link
Contributor

@belgamo belgamo commented Feb 19, 2020

Improvement based on issue #1230

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but you've forgot to update the usage of throwProtectedError in parse.

Also, instead of:

Use `dd` instead of `DD` for formatting days of the month using yyyy-MM-DD; see: https:\/\/git.io\/fxCyr

I prefer:

Use `dd` instead of `DD` (in `yyyy-MM-DD`) for formatting days of the month; see: https:\/\/git.io\/fxCyr

@belgamo
Copy link
Contributor Author

belgamo commented Feb 20, 2020

I like the idea but you've forgot to update the usage of throwProtectedError in parse.

Also, instead of:

Use `dd` instead of `DD` for formatting days of the month using yyyy-MM-DD; see: https:\/\/git.io\/fxCyr

I prefer:

Use `dd` instead of `DD` (in `yyyy-MM-DD`) for formatting days of the month; see: https:\/\/git.io\/fxCyr

Yes, I had forgotten that, but I notice and already fixed it! I ask you to review it again. I'll improve the message. Thank you!

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for waiting!

@kossnocorp kossnocorp merged commit 02f1ead into date-fns:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants