fix roundtrip bug with d/EEEE ordering in formats like PPPPP #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update snapshot.md
|
I'll appreciate it if you can provide an explanation for your changes. Thanks! |
|
@kossnocorp Updated the first comment to include a description |
kossnocorp
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anytime two tokens exist in a format string that have the same priority one needs to take precedent over the other when parsing otherwise incorrect values will be parsed.
The example that is shown in the snapshots that are now fixed are cases where E and d coexist such as PPPP. Before some locales would handle it find because E would come before d, but in locales where d came before E there were issues. So adding a sub priority so we can correctly sort which token takes precedent.
en-US : PPPP
'EEEE, MMMM do, yja : PPPP
y年M月d日EEEE