Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HungarianLocale): Use IE 11 friendly syntax for object keys #1842

Merged
merged 1 commit into from Jul 17, 2020
Merged

fix(HungarianLocale): Use IE 11 friendly syntax for object keys #1842

merged 1 commit into from Jul 17, 2020

Conversation

gottsohn
Copy link
Contributor

Fix for #1833

IE 11 doesn't support object keys as variables e.g {....[-1]: 1...}.
The keys must be string or number literals.

BillOTei
BillOTei approved these changes Jun 16, 2020
View reviewed changes
Copy link

@BillOTei BillOTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also, what is the point of using numbers between brackets for key assignment? I thought that was for with variables used as keys a = "b" c = {[a]: "d"}

@gottsohn
Copy link
Contributor Author

gottsohn commented Jun 16, 2020 •
edited

LGTM

LGTM.

Also, what is the point of using numbers between brackets for key assignment? I thought that was for with variables used as keys a = "b" c = {[a]: "d"}

Don't know but it works either way in ES5.

@afelicioni
Copy link

This shall also fix #1796

@afelicioni afelicioni mentioned this pull request Jun 19, 2020
Closed
kossnocorp
kossnocorp approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch!

@kossnocorp kossnocorp merged commit f1df9c2 into date-fns:master Jul 17, 2020
@kossnocorp kossnocorp mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kossnocorp kossnocorp kossnocorp approved these changes

@BillOTei BillOTei BillOTei approved these changes

Assignees
No one assigned
Labels
🐛 Bug 🌏 I18n ⛴ Ship it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gottsohn @afelicioni @kossnocorp @BillOTei