Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes formatDuration with Norwegian Locale Consistent with others #2631

Conversation

LucasHFS
Copy link
Contributor

attempt to solve #2469

@LucasHFS LucasHFS force-pushed the 2469/makes-formatDuration-norwegian-consistent branch from 9967b98 to 043662d Compare September 13, 2021 10:55
@tan75
Copy link
Contributor

tan75 commented Sep 14, 2021

@date-fns/i18n-nb
Hi,
could you please have a look?

@tan75 tan75 linked an issue Sep 14, 2021 that may be closed by this pull request
Copy link
Contributor

@kbrabrand kbrabrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@tan75 tan75 mentioned this pull request Sep 15, 2021
16 tasks
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@kossnocorp kossnocorp merged commit c5a0adc into date-fns:master Sep 17, 2021
tan75 pushed a commit to janziemba/date-fns that referenced this pull request Dec 27, 2021
…ns#2631) (closes date-fns#2469)

Changed: Made Norwegian `formatDuration` consistent with other locales by using numeric representation instead of written.

Co-authored-by: Lucas Silva <lucas.silva@codeminer42.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent use of numbers and written numbers across locales
4 participants