Fix corner cases #460
Merged
Fix corner cases #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leshakoss
changed the title
kossnocorp
reviewed
Apr 4, 2017
| new Date(NaN) | ||
| ) | ||
| assert(result === false) | ||
| }) |
There was a problem hiding this comment.
It's worth to add a tests case with isSameDay(new Date(NaN), new Date(NaN))
kossnocorp
approved these changes
Apr 4, 2017
| new Date(NaN) | ||
| ) | ||
| assert(result === false) | ||
| }) |
There was a problem hiding this comment.
Add test case for isAfter(new Date(NaN), new Date(NaN))
| it('throws an exception if the end date of the compared time interval is `Invalid Date`', function () { | ||
| var block = areIntervalsOverlapping.bind( | ||
| null, | ||
| {start: new Date(2016, 10, 3), end: new Date(2016, 10, 7)}, |
There was a problem hiding this comment.
Let's use RangeError for the exception.
| new Date(2012, 6 /* Jul */, 2) | ||
| ]) | ||
| assert(isNaN(result)) | ||
| }) |
There was a problem hiding this comment.
Let's add test case when the given array contains an unexpected value such as undefined.
CHANGELOG.md
Outdated
| @@ -328,6 +328,10 @@ This change log follows the format documented in [Keep a CHANGELOG]. | |||
| ) | |||
| ``` | |||
|
|
|||
| - **BREAKING**: functions now throw `RangeError` if optional values passed to `options` | |||
| are not `undefined` or have expected values. | |||
| This change is introduced for consistency with ECMAScript's `Intl` which does the same. | |||
There was a problem hiding this comment.
Add a comment about arithmetic operations with NaN
leshakoss
added a commit
that referenced
this pull request
Apr 14, 2017
* Invalid Date tests for `addX`, `setX` and `subX` * Invalid Date tests for `getX` * Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX` * Invalid Date tests for `isSameX` * Invalid Date tests for `differenceInX` * `isX(new Date(NaN))` tests * `isAfter`, `isBefore` and `isEqual` Invalid Date tests * Interval functions Invalid Date tests * `compareAsc` and `compareDesc` Invalid Date tests * `closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests * Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined * Test `parse` if baseDate is `Invalid Date` * `distanceInWords` and `distanceInWordsStrict` invalid values tests * Invalid `options.weekStartsOn` tests * Invalid value implementation fixes * `parse` implementation fix * `weekStartsOn` implementation fix * Rename `partialMethod` to `roundingMethod` * `distanceInWordsStrict` implementation fix * Rebuild typings * `toDate` implementation fix * Add CHANGELOG.md entry * Add missing tests * Make interval functions throw RangeError * Fix @throws docs messages * Add `@throws {RangeError}` to all functions docs * Add `@param [options.additionalDigits]` to all functions docs * Add `options.additionalDigits` tests to all functions * Complete corner cases changelog entry * Add missing `$ExpectedMistake`
leshakoss
added a commit
that referenced
this pull request
May 4, 2017
* Invalid Date tests for `addX`, `setX` and `subX` * Invalid Date tests for `getX` * Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX` * Invalid Date tests for `isSameX` * Invalid Date tests for `differenceInX` * `isX(new Date(NaN))` tests * `isAfter`, `isBefore` and `isEqual` Invalid Date tests * Interval functions Invalid Date tests * `compareAsc` and `compareDesc` Invalid Date tests * `closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests * Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined * Test `parse` if baseDate is `Invalid Date` * `distanceInWords` and `distanceInWordsStrict` invalid values tests * Invalid `options.weekStartsOn` tests * Invalid value implementation fixes * `parse` implementation fix * `weekStartsOn` implementation fix * Rename `partialMethod` to `roundingMethod` * `distanceInWordsStrict` implementation fix * Rebuild typings * `toDate` implementation fix * Add CHANGELOG.md entry * Add missing tests * Make interval functions throw RangeError * Fix @throws docs messages * Add `@throws {RangeError}` to all functions docs * Add `@param [options.additionalDigits]` to all functions docs * Add `options.additionalDigits` tests to all functions * Complete corner cases changelog entry * Add missing `$ExpectedMistake`
leshakoss
added a commit
that referenced
this pull request
May 20, 2017
* Invalid Date tests for `addX`, `setX` and `subX` * Invalid Date tests for `getX` * Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX` * Invalid Date tests for `isSameX` * Invalid Date tests for `differenceInX` * `isX(new Date(NaN))` tests * `isAfter`, `isBefore` and `isEqual` Invalid Date tests * Interval functions Invalid Date tests * `compareAsc` and `compareDesc` Invalid Date tests * `closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests * Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined * Test `parse` if baseDate is `Invalid Date` * `distanceInWords` and `distanceInWordsStrict` invalid values tests * Invalid `options.weekStartsOn` tests * Invalid value implementation fixes * `parse` implementation fix * `weekStartsOn` implementation fix * Rename `partialMethod` to `roundingMethod` * `distanceInWordsStrict` implementation fix * Rebuild typings * `toDate` implementation fix * Add CHANGELOG.md entry * Add missing tests * Make interval functions throw RangeError * Fix @throws docs messages * Add `@throws {RangeError}` to all functions docs * Add `@param [options.additionalDigits]` to all functions docs * Add `options.additionalDigits` tests to all functions * Complete corner cases changelog entry * Add missing `$ExpectedMistake`
leshakoss
added a commit
that referenced
this pull request
May 20, 2017
* Invalid Date tests for `addX`, `setX` and `subX` * Invalid Date tests for `getX` * Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX` * Invalid Date tests for `isSameX` * Invalid Date tests for `differenceInX` * `isX(new Date(NaN))` tests * `isAfter`, `isBefore` and `isEqual` Invalid Date tests * Interval functions Invalid Date tests * `compareAsc` and `compareDesc` Invalid Date tests * `closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests * Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined * Test `parse` if baseDate is `Invalid Date` * `distanceInWords` and `distanceInWordsStrict` invalid values tests * Invalid `options.weekStartsOn` tests * Invalid value implementation fixes * `parse` implementation fix * `weekStartsOn` implementation fix * Rename `partialMethod` to `roundingMethod` * `distanceInWordsStrict` implementation fix * Rebuild typings * `toDate` implementation fix * Add CHANGELOG.md entry * Add missing tests * Make interval functions throw RangeError * Fix @throws docs messages * Add `@throws {RangeError}` to all functions docs * Add `@param [options.additionalDigits]` to all functions docs * Add `options.additionalDigits` tests to all functions * Complete corner cases changelog entry * Add missing `$ExpectedMistake`
kossnocorp
pushed a commit
that referenced
this pull request
Jun 20, 2017
* Invalid Date tests for `addX`, `setX` and `subX` * Invalid Date tests for `getX` * Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX` * Invalid Date tests for `isSameX` * Invalid Date tests for `differenceInX` * `isX(new Date(NaN))` tests * `isAfter`, `isBefore` and `isEqual` Invalid Date tests * Interval functions Invalid Date tests * `compareAsc` and `compareDesc` Invalid Date tests * `closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests * Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined * Test `parse` if baseDate is `Invalid Date` * `distanceInWords` and `distanceInWordsStrict` invalid values tests * Invalid `options.weekStartsOn` tests * Invalid value implementation fixes * `parse` implementation fix * `weekStartsOn` implementation fix * Rename `partialMethod` to `roundingMethod` * `distanceInWordsStrict` implementation fix * Rebuild typings * `toDate` implementation fix * Add CHANGELOG.md entry * Add missing tests * Make interval functions throw RangeError * Fix @throws docs messages * Add `@throws {RangeError}` to all functions docs * Add `@param [options.additionalDigits]` to all functions docs * Add `options.additionalDigits` tests to all functions * Complete corner cases changelog entry * Add missing `$ExpectedMistake`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.