New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added locale en-GB #563
Added locale en-GB #563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍 Please fix the code style issue and we're good to go
* @category Locales | ||
* @summary English locale (United Kingdom). | ||
* @language English | ||
* @iso-639-2 eng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @author tag, like this:
* @author Alex [@glintik]{@link https://github.com/glintik}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, missed a comment in the last review. This code style issue:
LT: 'HH:mm', | ||
LTS: 'HH:mm:ss', | ||
L: 'DD/MM/YYYY', | ||
LL : 'D MMMM YYYY', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove extra space after key here and in two following lines. https://travis-ci.org/date-fns/date-fns/jobs/276343759#L490-L492
Sorry, forgot to run eslint. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@glintik while we're waiting for @kossnocorp to release this as a new version, could you please add |
It's released as Thank you! |
Hi,
Locale en-GB is added and tested.