Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add en-CA locale #688

Merged
merged 1 commit into from Feb 15, 2018

Conversation

markowsiak
Copy link
Member

Adds locale for English Canada

Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markowsiak
Copy link
Member Author

Thanks for checking that @leshakoss ! I've pushed up those changes 👍

Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 👍

@markowsiak markowsiak closed this Feb 13, 2018
@markowsiak markowsiak reopened this Feb 13, 2018
@markowsiak markowsiak closed this Feb 14, 2018
@markowsiak markowsiak reopened this Feb 14, 2018
@leshakoss leshakoss merged commit 8ba06f3 into date-fns:master Feb 15, 2018
@leshakoss
Copy link
Contributor

@markowsiak Thanks a lot for your contribution! I will try to release this as a part of v2.0.0-beta.1 as soon as possible (hopefully a few days). I will let you know when it’s released.

@markowsiak
Copy link
Member Author

No problem @leshakoss , thanks for the turn around as well 👍
I hope to add quite a few more locales in the coming weeks. Is Gitter the best way to keep in contact with you? Thanks again 💯

@leshakoss
Copy link
Contributor

@markowsiak it's best to write directly on my email (it's seen on my github profile). Please keep in mind that some locale API changes coming soon (see #660) but I think I will stabilize the API in a few days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants