Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic support for hu and lt localizations #864

Merged
merged 5 commits into from Sep 18, 2018

Conversation

izifortune
Copy link
Contributor

No description provided.

DESKTOP-QF4TFRB\HP and others added 2 commits August 30, 2018 12:19
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comments and also add an entry to the change log: https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md

src/esm/locale/index.js Outdated Show resolved Hide resolved
src/locale/index.js Outdated Show resolved Hide resolved
src/locale/hu/index.js Outdated Show resolved Hide resolved
src/locale/lt/index.js Outdated Show resolved Hide resolved
@kossnocorp
Copy link
Member

@leshakoss, please take a glance.

@reyrodrigez reyrodrigez mentioned this pull request Sep 18, 2018
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is looking good, thank you guys for your work!

@kossnocorp kossnocorp merged commit a5420d6 into date-fns:master Sep 18, 2018
@@ -0,0 +1,135 @@
var formatDistanceLocale = {
lessThanXSeconds: {
one: translate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that this could be improved somehow. formatDistance file doesn't has to have this exact structure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this is already merged 😀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a feeling that this could be improved somehow. formatDistance file doesn't has to have this exact structure

@leshakoss could you please elaborate what do you mean by that? Guys could improve in following PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case formatDistanceLocale object is not really needed because the logic is handled by translate function below

@kossnocorp
Copy link
Member

I'm going to release a new version soon. Stay tuned!

@kossnocorp
Copy link
Member

I've just published a new version with this locale date-fns@2.0.0-alpha.18. See the change log: https://gist.github.com/kossnocorp/a307a464760b405bb78ef5020a4ab136#v200-alpha18

Thank you again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants