New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic support for hu and lt localizations #864
Conversation
add basic support for hu and lt localizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the comments and also add an entry to the change log: https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md
@leshakoss, please take a glance. |
…u-lt-latest-version update version of lt and hu localizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is looking good, thank you guys for your work!
@@ -0,0 +1,135 @@ | |||
var formatDistanceLocale = { | |||
lessThanXSeconds: { | |||
one: translate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that this could be improved somehow. formatDistance
file doesn't has to have this exact structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this is already merged 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a feeling that this could be improved somehow.
formatDistance
file doesn't has to have this exact structure
@leshakoss could you please elaborate what do you mean by that? Guys could improve in following PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case formatDistanceLocale
object is not really needed because the logic is handled by translate
function below
I'm going to release a new version soon. Stay tuned! |
I've just published a new version with this locale Thank you again for your work! |
No description provided.