Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for getUnixTime #870

Merged
merged 1 commit into from Sep 25, 2018
Merged

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Sep 14, 2018

fix #372 again

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👌

getUnixTime is a fine function name but because it supposed to have the symmetric from function I suggest to rename to toUnixTime so the pair will be fromUnixTime.

@kossnocorp kossnocorp dismissed their stale review September 25, 2018 06:11

Scratch that, I forgot about getTime function

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, sorry about the confusion with the naming, I completely forgot about getTime.

@kossnocorp kossnocorp merged commit e48cdfb into date-fns:master Sep 25, 2018
@Kingwl Kingwl deleted the getUnixTime branch September 25, 2018 06:41
@Kingwl
Copy link
Contributor Author

Kingwl commented Sep 25, 2018

Is that mean we should rename the toUnix to toUnixTime?🤫

@kossnocorp
Copy link
Member

@Kingwl 😅

@kossnocorp
Copy link
Member

The function was released as date-fns@2.0.0-alpha.20. See the change log: https://gist.github.com/kossnocorp/a307a464760b405bb78ef5020a4ab136#v200-alpha20 Thank you again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get unix timestamp of given date
2 participants