Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent country variation: Singapore #1742

Open
baltpeter opened this issue May 20, 2022 · 0 comments
Open

Inconsistent country variation: Singapore #1742

baltpeter opened this issue May 20, 2022 · 0 comments
Labels
bug Something isn't working test

Comments

@baltpeter
Copy link
Member

We've decided that Singapore should be written as "Republic of Singapore":

const country_name_variations = ['United States of America', 'The Netherlands', 'Republic of Singapore'];

But we also allow the native property from the countries-list library:

const isCountry = (str: string) =>
Object.entries(countries).some(
([country_code, c]) =>
(!variation_country_codes.includes(country_code) && str == c.name) || str === c.native
) || country_name_variations.includes(str);

And that's "Singapore" in that case. We currently have records with both variations.

@baltpeter baltpeter added bug Something isn't working test labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test
Development

No branches or pull requests

1 participant