Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow the phone number whitespace format output by libphonenumber #2165

Open
baltpeter opened this issue Mar 23, 2023 · 0 comments
Open

Comments

@baltpeter
Copy link
Member

For the suggestions and in the company-json-generator, we format phone numbers using libphonenumber. But so far, we have also allowed additional spaces to be added.

This is quite annoying because it makes suggestion PRs much harder to read:

ad752a9#diff-2e2c693eeb489acb22a617dd6fe60a96dd1f1db5b2c04418157418d52b5e49d5R17-R18

And if you don't manually edit the PR (which is even more annoying), we will eventually end up with the libphonenumber formatting, anyway.

As such, I propose that we add a test that always enforces the libphonenumber formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant