Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for YYYYMM in isoparser #546

Closed
pganssle opened this issue Dec 6, 2017 · 2 comments
Closed

Drop support for YYYYMM in isoparser #546

pganssle opened this issue Dec 6, 2017 · 2 comments
Labels
bug help wanted isoparser medium-difficulty parser
Milestone
2.7.0

Comments

@pganssle
Copy link
Member

pganssle commented Dec 6, 2017 •
edited
Loading

According to Wikipedia YYYYMM is explicitly not supported in ISO-8601, so we should drop support for it. Hopefully this does not add undue complication into the algorithm.

See #489 for initial isoparse implementation.
@pganssle pganssle added this to the 2.7.0 milestone Dec 6, 2017
@kirit93
Copy link
Contributor

kirit93 commented Dec 8, 2017

@pganssle has this issue been assigned or can I take a crack at it?

@pganssle
Copy link
Member Author

pganssle commented Dec 8, 2017

@kirit93 During the sprint, @yoney said he was going to take a look at it this weekend, but I talked to him and he said you can go for it. Just mention it here if you end up not doing it.

@kirit93 kirit93 mentioned this issue Dec 8, 2017
Merged
@pganssle pganssle mentioned this issue Mar 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted isoparser medium-difficulty parser
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@pganssle @kirit93