Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong link syntax in relativedelta examples #670

Closed
pganssle opened this issue Apr 12, 2018 · 4 comments
Closed

Wrong link syntax in relativedelta examples #670

pganssle opened this issue Apr 12, 2018 · 4 comments

Comments

@pganssle
Copy link
Member

I noticed that in the relativedelta examples there is a link using the wrong syntax for RST, so it's not getting turned into a link.

The issue is this line, which currently reads:

[http://www.cl.cam.ac.uk/~mgk25/iso-time.html ISO year week number notation]

But should read:

ISO year week number notation

It needs to be turned into RST syntax, which is I think:

`ISO year week number notation <http://www.cl.cam.ac.uk/~mgk25/iso-time.html>`_
@orsonadams
Copy link
Contributor

orsonadams commented Apr 20, 2018

This should work:

` ISO year week number notation`_

.. _ISO yeaar week number notation: http://www.cl.cam.ac.uk/~mgk25/iso-time.html

@orsonadams
Copy link
Contributor

I was looking around for a way to build the docs locally. Advice? I would clean up as many of these as possible but dont want to push and test.

@pganssle
Copy link
Member Author

tox -e docs will build the docs with all the tests. You can find the output in .tox/docs_out.

You can also enter the docs folder and type make html, then the output will be built in the _build.

I think I would prefer the inline syntax mentioned in my original post:

`ISO year week number notation <http://www.cl.cam.ac.uk/~mgk25/iso-time.html>`_

@pganssle pganssle added this to the 2.7.3 milestone Apr 25, 2018
@pganssle
Copy link
Member Author

Just noticed another minor typo that can be fixed at the same time. The tzfile documentation reads: "This is a tzinfo subclass thant allows one to". Obviously that needs s/thant/that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants