Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[views] Puppeteer page crashes occasionally #314

Closed
3 of 4 tasks
anuveyatsu opened this issue Jul 6, 2018 · 1 comment
Closed
3 of 4 tasks

[views] Puppeteer page crashes occasionally #314

anuveyatsu opened this issue Jul 6, 2018 · 1 comment
Assignees

Comments

@anuveyatsu
Copy link
Member

anuveyatsu commented Jul 6, 2018

Error log 1:

(node:26) UnhandledPromiseRejectionWarning: Error: Page crashed!
    at Page._onTargetCrashed (/frontend-app/node_modules/puppeteer/lib/Page.js:156:24)
    at CDPSession.Page.client.on.event (/frontend-app/node_modules/puppeteer/lib/Page.js:132:56)
    at emitOne (events.js:116:13)
    at CDPSession.emit (events.js:211:7)
    at CDPSession._onMessage (/frontend-app/node_modules/puppeteer/lib/Connection.js:232:12)
    at Connection._onMessage (/frontend-app/node_modules/puppeteer/lib/Connection.js:119:19)
    at emitOne (events.js:116:13)
    at WebSocket.emit (events.js:211:7)
    at Receiver.receiverOnMessage (/frontend-app/node_modules/ws/lib/websocket.js:720:20)
    at emitOne (events.js:116:13)

Error log 2:

{ Error: Protocol error (Emulation.setDeviceMetricsOverride): Target closed.
    at Promise (/frontend-app/node_modules/puppeteer/lib/Connection.js:202:56)
    at new Promise (<anonymous>)
    at CDPSession.send (/frontend-app/node_modules/puppeteer/lib/Connection.js:201:12)
    at EmulationManager.emulateViewport (/frontend-app/node_modules/puppeteer/lib/EmulationManager.js:40:20)
    at Page.setViewport (/frontend-app/node_modules/puppeteer/lib/Page.js:701:54)
    at Page._screenshotTask (/frontend-app/node_modules/puppeteer/lib/Page.js:812:18)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Error log 3:

Error: waiting for selector "svg" failed: timeout 30000ms exceeded
    at Timeout.WaitTask._timeoutTimer.setTimeout (/frontend-app/node_modules/puppeteer/lib/FrameManager.js:841:60)
    at ontimeout (timers.js:498:11)
    at tryOnTimeout (timers.js:323:5)
    at Timer.listOnTimeout (timers.js:290:5)

Error log 4:

Error: Navigation Timeout Exceeded: 30000ms exceeded
    at Promise.then (/frontend-app/node_modules/puppeteer/lib/NavigatorWatcher.js:73:21)
    at <anonymous>

Acceptance criteria

  • page doesn't crash and the exception is handled

Tasks

  • analyse error source
  • handle page errors
  • improve logs

puppeteer/puppeteer#1401
puppeteer/puppeteer#1385

@anuveyatsu anuveyatsu added this to the Sprint - 16 Jul 2018 milestone Jul 6, 2018
@anuveyatsu anuveyatsu self-assigned this Jul 6, 2018
@anuveyatsu
Copy link
Member Author

FIXED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant