Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to markdown-it from marked #75

Closed
7 tasks done
rufuspollock opened this issue Aug 22, 2017 · 3 comments
Closed
7 tasks done

Switch to markdown-it from marked #75

rufuspollock opened this issue Aug 22, 2017 · 3 comments
Assignees

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Aug 22, 2017

Why?

Other projects I've looked at seem to use it / consider it e.g. hackmd

Acceptance criteria

  • we use markdown-it to convert markdown into html
  • supports headers as anchors
  • supports block containers (:::info)

Tasks

@rufuspollock
Copy link
Member Author

@anuveyatsu have we checked markdown-it can do everything we are using marked for see e.g. the docs route for an example of full usage.

@anuveyatsu
Copy link
Member

anuveyatsu commented Aug 30, 2017

@rufuspollock yes.
Headings can have an embedded anchor tag like on GitHub using plugins:

markdown-it also discussing having it as built-in feature here - markdown-it/markdown-it#28 - but probably not soon.

Re other options we're using with marked:

  • GFM and tables are enabled by default in markdown-it
  • smartLists - not sure what exactly does this option in marked - behaves similarly to me with either turned on/off.
  • smartypants - there is something similar called typographer in markdown-it.

@anuveyatsu anuveyatsu added this to the Sprint - 11 Sep 2017 milestone Sep 4, 2017
anuveyatsu added a commit that referenced this issue Sep 4, 2017
* markdown-it as the markdown processor
* markdown-it-anchor for making titles as anchors
* markdown-it-container for supporting block containers, e.g., :::info
@anuveyatsu
Copy link
Member

FIXED. We do CSS stuff in a separate issue, e.g., for block containers. Atm, behavior is as the following:

:::info
some info message
:::

==>

<div class="info">
  <p>some info message</p>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants