Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassportJS based Social auth feature #199

Open
solancer opened this issue Apr 11, 2020 · 3 comments
Open

PassportJS based Social auth feature #199

solancer opened this issue Apr 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@solancer
Copy link

Email signup and login is getting outdated lately and people prefer oAuth based logins from their existing logins. Add passport strategies for Facebook, Google, Twitter, Github.

@davellanedam
Copy link
Owner

I prefer email based always. But some other people might like oAuth. Can you please help out with this? You are more than welcome to create a PR for this. Thanks!

@macizomedia
Copy link

Hello, I am having an error on this line when retrieving /profile data.

I did console log the user and is ok, but somehow something is not right with the callback.

Where should I be looking?

const jwtLogin = new JwtStrategy(jwtOptions, (payload, done) => { User.findById(payload.data._id, (err, user) => { if (err) { return done(err, false) } return !user ? done(null, false) : done(null, user) }) })

error
TypeError: callback is not a function
at JwtStrategy.strategy.success

Any Idea what might be wrong?

Thanks a lot

@davellanedam davellanedam added the enhancement New feature or request label Jul 30, 2020
@davellanedam
Copy link
Owner

Hello, I am having an error on this line when retrieving /profile data.

I did console log the user and is ok, but somehow something is not right with the callback.

Where should I be looking?

const jwtLogin = new JwtStrategy(jwtOptions, (payload, done) => { User.findById(payload.data._id, (err, user) => { if (err) { return done(err, false) } return !user ? done(null, false) : done(null, user) }) })

error
TypeError: callback is not a function
at JwtStrategy.strategy.success

Any Idea what might be wrong?

Thanks a lot

Hey I just saw this, I am sorry, you should have opened a new issue, this issue is an enhancement. Were you able to solve your issue? Please Let's move this to a new issue if you still haven't solved this yet. If you did, can you please delete the comment so we keep this thread as an enhancement? Thanks, and I am really sorry again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants