Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth license checking management #136

Closed
wants to merge 1 commit into from

Conversation

hervenivon
Copy link

Hi,

Nice to meet you.

I'm in the process of license validation and your tool was the closest to what I was looking for. It only missed a depth option management.

Here it is. I leveraged the depth option of read-installed package. It is not perfect because sometimes a npm install may installed dependencies of your direct dependencies at level 0. Anyway, it still allows filtering of node_modules.

I also documented the start option. Which I would I love to name path.

@aruizca
Copy link

aruizca commented Nov 12, 2018

@hervenivon FYI You have merge conflits.

@aruizca
Copy link

aruizca commented Nov 12, 2018

Hi @davglass Is there anything else we can help with to get this merged?

@hervenivon
Copy link
Author

I'm not using it anymore. It's unfortunate, but we may lose my PR.

@davglass davglass closed this in b897345 Jan 10, 2019
@davglass
Copy link
Owner

Published in license-checker@25.0.0

@aruizca
Copy link

aruizca commented Jan 10, 2019

Thanks @davglass
Could you update the README documentation with the new arguments please?
Cheers

@davglass
Copy link
Owner

Just pushed up 25.0.1 with an updated README.

@aruizca
Copy link

aruizca commented Jan 10, 2019

I think you forgot about the depth option ;-)

@davglass
Copy link
Owner

davglass commented Jan 10, 2019 via email

@aruizca
Copy link

aruizca commented Jan 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants